From ee5efdf5b9ef8996cebd2b95d159edef77c91656 Mon Sep 17 00:00:00 2001 From: Marc Herbert Date: Wed, 7 Aug 2024 16:31:06 +0000 Subject: [PATCH] src/arch/xtensa/CMakeLists.txt: drop bogus, non-portable -Wl,-EL As already discussed in commit bcbcec79e582 ("cmake: drop binutils-specific '-Wl,-EL' option") and commit ee58fef9212f ("smex/cmake: move -Wl,EL option to target_linker_options() for clang") and their corresponding reviews on GitHub, this binutils-specific, endianness option makes no difference and is causing clang compatibility issues. It's now getting in the way of #9351 "Add the new platform ACP_7_0". I ran `./scripts/docker-run.sh ./scripts/xtensa-build-all.sh -a` with and without it and there was absolutely zero binary difference. I was added in 2019 by giant commit e0ba98d21ae8 ("cmake: add CMakeLists for firmware build") without any rationale of why it would be needed. Signed-off-by: Marc Herbert --- src/arch/xtensa/CMakeLists.txt | 1 - 1 file changed, 1 deletion(-) diff --git a/src/arch/xtensa/CMakeLists.txt b/src/arch/xtensa/CMakeLists.txt index 45d6782cc22e..9828d2a56992 100644 --- a/src/arch/xtensa/CMakeLists.txt +++ b/src/arch/xtensa/CMakeLists.txt @@ -123,7 +123,6 @@ target_compile_options(sof_options INTERFACE $<$: -${optimization_flag} -g -Wall -Werror - -Wl,-EL -Wmissing-prototypes -Wpointer-arith ${XTENSA_C_FLAGS}