-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-introducing state change in dai_comp_trigger_internal() breaks some tests from Intel CI #8920
Comments
@LaurentiuM1234 probably the best thing todo is to break down the changes into small bi-sectable patches and upstream them incrementally. This would allow more specific targeting when the issue is introduced. |
@LaurentiuM1234 are we good to close now that #8859 is merged or more still todo ? |
This issue was actually created by the introduction of #8859 (1bf6b8c). I think the question still stands: why does that code bit break Intel test(s) if made IPC version-agnostic? |
Stable branched for 2.10, nobody assigned to work on this, so moving this to 2.11. |
No owner -> v2.12 |
Attempting to bring back the state transition logic in
dai-zephyr
'sdai_comp_trigger_internal()
that was initially removed by 6ffb052 seems to break some tests from the Intel CI. The logic is needed for NXP platforms and is re-introduced by #8859 via 59d05a3.As a workaround, the state transition logic has been made IPC3-specific but it might be worth looking into this and trying to make the code IPC version-agnostic if possible.
Links to the aforementioned failing CI builds:
The text was updated successfully, but these errors were encountered: