Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] dai-zephyr.c: remove DAI driver specific logic from COMP_TRIGGER_RELEASE code #9002

Open
kv2019i opened this issue Apr 3, 2024 · 2 comments
Labels
bug Something isn't working as expected Zephyr Issues only observed with Zephyr integrated
Milestone

Comments

@kv2019i
Copy link
Collaborator

kv2019i commented Apr 3, 2024

Describe the bug
Follow-up to #8995

The code on SOF side should not have conditional logic based on DAI type . The DAI interface should abstract the pause/resume behaviour so that SOF side code should be uniform.

Core in question

	if (!(dd->dai->dma_caps & DMA_CAP_HDA))
			audio_stream_reset(&dd->dma_buffer->stream);
@kv2019i kv2019i added bug Something isn't working as expected Zephyr Issues only observed with Zephyr integrated labels Apr 3, 2024
@lgirdwood lgirdwood added this to the v2.10 milestone Apr 16, 2024
@lgirdwood
Copy link
Member

@abonislawski @softwarecki fyi - will need to move into Zephyr.

@lgirdwood lgirdwood modified the milestones: v2.10, v2.11 May 28, 2024
@kv2019i kv2019i modified the milestones: v2.11, v2.12 Sep 5, 2024
@kv2019i
Copy link
Collaborator Author

kv2019i commented Sep 5, 2024

No owner -> v2.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected Zephyr Issues only observed with Zephyr integrated
Projects
None yet
Development

No branches or pull requests

2 participants