Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add ABI versioning to IPC4 interface #9080

Open
kv2019i opened this issue Apr 24, 2024 · 3 comments
Open

[FEATURE] Add ABI versioning to IPC4 interface #9080

kv2019i opened this issue Apr 24, 2024 · 3 comments
Assignees
Labels
ABI ABI change involved enhancement New feature or request IPC4 Issues observed with IPC4 (same IPC as Windows)

Comments

@kv2019i
Copy link
Collaborator

kv2019i commented Apr 24, 2024

Is your feature request related to a problem? Please describe.
SOF has established ABI process for IPC3 extensions -> https://thesofproject.github.io/latest/contribute/process/abiprocess.html

We do not have same for IPC4 yet and no guidelines how to push IPC4 changes through the process. With release of SOF2.7, we now have first shipping product that is using SOF IPC4 interface (Intel Meteor Lake), so there is now also the need to track ABI extensions. Notably, FW currently sets:

#define SOF_ABI_MAJOR 3
#define SOF_ABI_MINOR 30

... and there's no way to describe IPC4 version.

Describe the solution you'd like
Something like IPC3.

Describe alternatives you've considered

Additional context
Triggered by review of #9032

@kv2019i kv2019i added the enhancement New feature or request label Apr 24, 2024
@kv2019i
Copy link
Collaborator Author

kv2019i commented Apr 24, 2024

FYI to @lgirdwood @abonislawski

@kv2019i kv2019i added ABI ABI change involved IPC4 Issues observed with IPC4 (same IPC as Windows) labels Apr 24, 2024
@kv2019i
Copy link
Collaborator Author

kv2019i commented Apr 24, 2024

FYI to SOF Linux driver folks @plbossart @ranj063 @bardliao @ujfalusi

@kv2019i kv2019i changed the title [FEATURE] Add ABI versinoning to IPC4 interface [FEATURE] Add ABI versioning to IPC4 interface Apr 24, 2024
@lgirdwood
Copy link
Member

Ack, we can do the same as IPC3 - i.e. we label and create a github project to do semantic versioning of IPC4 ABI in a backwards compatible manner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ABI ABI change involved enhancement New feature or request IPC4 Issues observed with IPC4 (same IPC as Windows)
Projects
None yet
Development

No branches or pull requests

4 participants