Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] enabling telemetry breaks shell and winconsole #9513

Closed
kv2019i opened this issue Sep 25, 2024 · 4 comments
Closed

[BUG] enabling telemetry breaks shell and winconsole #9513

kv2019i opened this issue Sep 25, 2024 · 4 comments
Labels
bug Something isn't working as expected LNL Applies to Lunar Lake platform

Comments

@kv2019i
Copy link
Collaborator

kv2019i commented Sep 25, 2024

Describe the bug
It seems following debug features are broken on multiple Intel targets:

... it turns out this is related to enabling SOF telemetry with debug window backend in #9186 .

In theory these shouldn't conflict, shell backend is using debug window slot 0 (2.0), while winconsole is using window 3 (3.0), while telemetry is hardcoded to use 2.1.

To Reproduce
Build with above overlays.

Reproduction Rate
100% on Intel LNL.

Expected behavior
telemetry should not affect uses of other memory window users.

Impact
debug feature unavailable

Environment

  1. Branch name and commit hash of the 2 repositories: sof (firmware/topology) and linux (kernel driver).
  2. Name of the topology file
    • Topology: n/a
  3. Name of the platform(s) on which the bug is observed.
    • Platform: Intel lnl
@kv2019i kv2019i added bug Something isn't working as expected LNL Applies to Lunar Lake platform labels Sep 25, 2024
@kv2019i
Copy link
Collaborator Author

kv2019i commented Sep 25, 2024

@tobonex @jsarha any ideas? We hit this with @ujfalusi

@tobonex
Copy link
Contributor

tobonex commented Sep 25, 2024

@kv2019i Window 3 is used by performance measurements. Try disabling CONFIG_SOF_TELEMETRY_PERFORMANCE_MEASUREMENTS to check.

@kv2019i
Copy link
Collaborator Author

kv2019i commented Sep 25, 2024

@tobonex thanks, aa, I missed this:

#define ADSP_PMW ((volatile uint32_t *) \
»       »        (sys_cache_uncached_ptr_get((__sparse_force void __sparse_cache *) \
»       »       »       »            (WIN3_MBASE + WIN3_OFFSET))))

So winconsole is clearly conflicting and you can use either/or.

This doesn't explain the conflict with shell, but the shell overlay also enables the winconsole, so maybe that causes the problem.

@kv2019i
Copy link
Collaborator Author

kv2019i commented Sep 26, 2024

Closed via #9514

@kv2019i kv2019i closed this as completed Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected LNL Applies to Lunar Lake platform
Projects
None yet
Development

No branches or pull requests

2 participants