-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add $SOF_CC_BASE variable for building XTOS with clang-based, Cadence toolchains #9358
Conversation
We can't have a shebang and of course all variables are unused. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
"COMPILER" is a very common name with a high risk of collision. Don't use it for a minor, local variable. This also reduces confusion. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
If the user requested the Cadence toolchain by defining $XTENSA_TOOLS_ROOT, then do not "correct" the user and fallback on gcc when that variable is wrong. Fail and point at the problem instead. No one ever pays attention to build logs; as shown by new warnings being submitted on a regular basis. This also removes the local variable "XCC", the name of which was collision-prone and confusingly capitalized. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
There is a synchronization outage following some VM migration (internal issue DIO 18204) but I checked the test results on the internal site and they are all fine, just the known LNL failures and that's it. |
This is required to allow building XTOS with newer, clang-based, Cadence toolchains as just submitted for ACP_7_0 in thesofproject#9351 Signed-off-by: Marc Herbert <marc.herbert@intel.com>
It was awkward to depend on ZEPHYR_TOOLCHAIN_VARIANT when the testbench has absolutely nothing to do with it. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
@lrudyX , @wszypelt there was some network problem in https://sof-ci.01.org/sof-pr-viewer/#/build/PR9358/build14153658 for "Copy build to DUT?DUT_CONFIG=LNL)"
The LNL build was fine so that failure was not related to this PR:
|
@marc-hb Unfortunately, there was an error with the LNL machine, the tests are being repeated now |
https://sof-ci.01.org/sof-pr-viewer/#/build/PR9358/build14154731 is green now, thanks @wszypelt ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works fine with all compilers for AMD platforms.
Thanks @marc-hb
As required by ACP_7_0 addition submitted in #9351
Other related cleanups, see commit messages.
Switch rebuild-testbench.sh to new variable.