Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add $SOF_CC_BASE variable for building XTOS with clang-based, Cadence toolchains #9358

Merged
merged 5 commits into from
Aug 14, 2024

Commits on Aug 9, 2024

  1. set_xtensa_params.sh: silence warnings which are wrong when sourced

    We can't have a shebang and of course all variables are unused.
    
    Signed-off-by: Marc Herbert <marc.herbert@intel.com>
    marc-hb committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    9691b6b View commit details
    Browse the repository at this point in the history
  2. xtensa-build-all.sh: rename local variable COMPILER to build_dir_suffix

    "COMPILER" is a very common name with a high risk of collision. Don't
    use it for a minor, local variable. This also reduces confusion.
    
    Signed-off-by: Marc Herbert <marc.herbert@intel.com>
    marc-hb committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    b29d34a View commit details
    Browse the repository at this point in the history
  3. xtensa-build-all.sh: do not fallback on gcc when xcc dir is wrong

    If the user requested the Cadence toolchain by defining
    $XTENSA_TOOLS_ROOT, then do not "correct" the user and fallback on gcc
    when that variable is wrong. Fail and point at the problem instead. No
    one ever pays attention to build logs; as shown by new warnings being
    submitted on a regular basis.
    
    This also removes the local variable "XCC", the name of which was
    collision-prone and confusingly capitalized.
    
    Signed-off-by: Marc Herbert <marc.herbert@intel.com>
    marc-hb committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    7826d43 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2024

  1. scripts: add new SOF_CC_BASE={xcc,clang,gcc} variable

    This is required to allow building XTOS with newer, clang-based, Cadence
    toolchains as just submitted for ACP_7_0 in thesofproject#9351
    
    Signed-off-by: Marc Herbert <marc.herbert@intel.com>
    marc-hb committed Aug 10, 2024
    Configuration menu
    Copy the full SHA
    7a8c1b7 View commit details
    Browse the repository at this point in the history
  2. rebuild-testbench.sh: switch to new SOF_CC_BASE variable

    It was awkward to depend on ZEPHYR_TOOLCHAIN_VARIANT when the testbench
    has absolutely nothing to do with it.
    
    Signed-off-by: Marc Herbert <marc.herbert@intel.com>
    marc-hb committed Aug 10, 2024
    Configuration menu
    Copy the full SHA
    932ca92 View commit details
    Browse the repository at this point in the history