[cavs2.5-001] topology1: sof-hda-generic: enable Waves playback #9427
Conversation
macchian
requested review from
marc-hb,
lgirdwood,
plbossart,
mmaka1,
lbetlej and
dbaluta
as code owners
|
Firmware failed to boot all across the board in https://sof-ci.01.org/sofpr/PR9427/build7557/devicetest/index.html |
|
The testbench CI failure is not related to this PR. |
I think I know what's happening. It's the same rimage "bufferfly effect" that I found (and fixed) in stable-v2.2. I re-opened #9340 |
@marc-hb , you are right, the #9340 fixed the issue that we verified from our end. |
| # | ||
| # Pipeline Endpoints for connection are : | ||
| # | ||
| # host PCM_P -- B0 --> EQIIR0 -> B1 --> Waves -- B2 --> sink DAI0 |
There was a problem hiding this comment.
In fact eq-iir is only needed by dts, not by waves. pipe-waves-codec-playback is enough.
There was a problem hiding this comment.
@johnylin76 you are right! Add Barry from Waves, @barry-waves suggest that remove the eqiir from this. Because the eqiir only requires when demux to 4ch speakers. Will update the PR soon.
Reuse the pipe-wave-codec-playback.m4 and enable this pipeline on HDA0 for speaker/headphone playaback. HDA0.OUT dai pipeline is included for codec adapter widget connection. Signed-off-by: Mac Chiang <mac.chiang@intel.com>
macchian
force-pushed
the
dev-waves-codec
branch
from
8d4a493
to
71dd222
Compare
kv2019i
changed the title
There was a problem hiding this comment.
@mwasko @abonislawski @marcinszkudlinski fyi - pls review/merge
mwasko
merged commit 181bfe1
into
thesofproject:cavs2.5-001-drop-stable
Create eq_iir + waves pipeline: pipe-eq-iir-waves-codec-playback.m4 and enable this pipeline on HDA0 for speaker/headphone playaback. HDA0.OUT dai pipeline is included for codec adapter widget connection.