Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve documentation for Playwright tests. #348

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Improve documentation for Playwright tests. #348

merged 1 commit into from
Aug 29, 2024
+9 −3

Conversation

whusterj
Copy link
Member

What this does

  • Changes some missed references to CYPRESS to PLAYWRIGHT in .env.example, and corrects the env variable name for PLAYWRIGHT_TEST_BASE_URL.
  • Adds additional installation steps to README.md that are necessary to run Playwright locally

@whusterj whusterj self-assigned this Aug 29, 2024
@whusterj whusterj added In Progress High Priority An issue or Pull Request that should take priority over all others. Use sparingly. labels Aug 29, 2024
@oudeismetis oudeismetis temporarily deployed to tn-spa-bootstrapper-pr-348 August 29, 2024 16:49 Inactive
whusterj
whusterj commented Aug 29, 2024
View reviewed changes
Copy link
Member Author

@whusterj whusterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's the last of the references to Cypress. Also added missing install steps for Playwright.

@whusterj whusterj merged commit 85b0cd5 into main Aug 29, 2024
17 of 18 checks passed
@whusterj whusterj deleted the docs/e2e-tests branch August 29, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@whusterj whusterj

Labels
High Priority An issue or Pull Request that should take priority over all others. Use sparingly. In Progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@whusterj @oudeismetis