Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for all Dockerfile commands #44

Open
nextrevision opened this issue Aug 13, 2015 · 4 comments
Open

Add support for all Dockerfile commands #44

nextrevision opened this issue Aug 13, 2015 · 4 comments
Milestone

Comments

@nextrevision
Copy link
Member

No description provided.

@nextrevision
Copy link
Member Author

Does it make sense to make the workflow look like below?

cyclops> COPY test.txt /tmp/
cyclops> :commit
cyclops> :run COPY test2.txt /tmp/

@cllunsford
Copy link
Member

My initial preference is to directly alias the commands, so:

:COPY test.txt /tmp/

for when you mean to copy

and

COPY test.txt /tmp/
:run COPY test2.txt /tmp/

would literally execute /bin/sh -c "COPY test.txt /tmp/

@nextrevision
Copy link
Member Author

What about ephemeral COPY operations?

@cllunsford
Copy link
Member

I think COPY operations (and other meta-directives like EXPOSE, CMD) have less of a need for ephemeral as default. In these cases, you'd have to just :b if you didn't like the outcome.

Or we could opt to make :COPY ephemeral by default (essentially equivalent to our existing :eval). So you would have to run

:COPY test.txt /tmp
:commit

I think it's more likely that people will COPY and then do something after that, and so the :commit is redundant. It is a bit of a pain that it wouldn't be consistent across the board. Maybe our :run for auto-commit should be changed.
like:

:COPY test.txt /tmp/ <= ephemeral
:commit
or in one line:
:COPY!
or
:!COPY

We could do the same for :run and basically remove :eval

these are equivalent:
<nothing>
:run
and will need to be followed by a :commit

and these are equivalent
:!
:run!

@cllunsford cllunsford modified the milestone: 0.2.0 Aug 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants