Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shifty fails to detect active website during full screen video in Safari #98

Open
momenabdelkarim opened this issue Mar 10, 2020 · 2 comments
Labels

Comments

@momenabdelkarim
Copy link

Disabling Night Shift for a website on Safari doesn't work if you're playing a video in full screen. I tested this on Youtube and Netflix. It works on Chrome though.

To reproduce:

  1. Open Safari
  2. Open any Youtube video
  3. In Shifty menu, disable Night Shift "for YouTube.com". Night Shift should turn off now.
  4. Enter full screen for the video. Night Shift is automatically re-enabled. If you open the Shifty menu you'll notice Shifty stops recognizing which website you're on in Safari.
@choco choco added the bug label Mar 10, 2020
@choco
Copy link
Collaborator

choco commented Mar 10, 2020

I have this fixed in my own branch. You can use the build in this comment if you'd like #90 (comment) and let me know how it goes for you (it also includes some optimizations specifically for Safari).
I would really want to find time to clean up and push a PR but I've been super busy.

@zdlo
Copy link

zdlo commented May 31, 2022

Is choco's branch still the only way to make fullscreen Safari work with Shifty, after two years?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants