-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to pyproject.toml #311
Comments
@VannTen: Please ensure the request meets the requirements listed here. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @sesheta can i work on the issue? |
Go for it ! 👍
|
What's the use of below option? Lines 42 to 47 in 1dc9de8
Below option can be written with the help of dynamic-metadata in pyproject.toml but this feature is in beta phase and it may change as pointed here Lines 37 to 41 in 1dc9de8
Can we write minimum config in pyproject.toml and the rest in |
On Fri, Oct 07, 2022 at 11:46:17AM -0700, ChandanChainani wrote:
@sesheta @VannTen
What's the use of below option?
https://github.com/thoth-station/analyzer/blob/1dc9de88a01fffdf5185f8caf8b522abbc49ef70/setup.py#L42-L47
This is sphinx integration, see https://www.sphinx-doc.org/pl/master/usage/advanced/setuptools.html
Below option can be written with the help of [dynamic-metadata](https://setuptools.pypa.io/en/latest/userguide/pyproject_config.html#dynamic-metadata) in pyproject.toml but this feature is in beta phase and it may change as pointed [here](https://setuptools.pypa.io/en/latest/userguide/pyproject_config.html#setuptools-specific-configuration)
https://github.com/thoth-station/analyzer/blob/1dc9de88a01fffdf5185f8caf8b522abbc49ef70/setup.py#L37-L41
Can we write minimum config in pyproject.toml and the rest in `setup.cfg`?
No problem to use the beta dynamic-metadata support ; setup.cfg is
probably needed for sphinx though, there is not support for having it
directly in pyproject.toml yet AFAIK.
|
…pyproject.toml Migrate setup.py to pyproject.toml (#311)
Translate setup.py into a pyproject.toml file
/kind feature
/triage accepted
/sig stack-guidance
/good-first-issue
/label hacktoberfest
Parent issue: thoth-station/core#360
The text was updated successfully, but these errors were encountered: