Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to pyproject.toml #311

Closed
VannTen opened this issue Sep 26, 2022 · 5 comments · Fixed by #312
Closed

Migrate to pyproject.toml #311

VannTen opened this issue Sep 26, 2022 · 5 comments · Fixed by #312
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. hacktoberfest Issues targeting the hacktoberfest participants. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. sig/stack-guidance Categorizes an issue or PR as relevant to SIG Stack Guidance. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@VannTen
Copy link
Member

VannTen commented Sep 26, 2022

Translate setup.py into a pyproject.toml file

/kind feature
/triage accepted
/sig stack-guidance
/good-first-issue
/label hacktoberfest

Parent issue: thoth-station/core#360

@sesheta
Copy link
Member

sesheta commented Sep 26, 2022

@VannTen:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

Translate setup.py into a pyproject.toml file

/kind feature
/triage accepted
/sig stack-guidance
/good-first-issue
/label hacktoberfest

Parent issue: thoth-station/core#360

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sesheta sesheta added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on. sig/stack-guidance Categorizes an issue or PR as relevant to SIG Stack Guidance. hacktoberfest Issues targeting the hacktoberfest participants. labels Sep 26, 2022
@ChandanChainani
Copy link
Contributor

Hi @sesheta can i work on the issue?

@VannTen
Copy link
Member Author

VannTen commented Oct 7, 2022 via email

@ChandanChainani
Copy link
Contributor

@sesheta @VannTen

What's the use of below option?

analyzer/setup.py

Lines 42 to 47 in 1dc9de8

command_options={
"build_sphinx": {
"version": ("setup.py", VERSION),
"release": ("setup.py", VERSION),
}
},

Below option can be written with the help of dynamic-metadata in pyproject.toml but this feature is in beta phase and it may change as pointed here

analyzer/setup.py

Lines 37 to 41 in 1dc9de8

packages=[
"thoth.analyzer",
],
zip_safe=False,
install_requires=get_install_requires(),

Can we write minimum config in pyproject.toml and the rest in setup.cfg?

@VannTen
Copy link
Member Author

VannTen commented Oct 10, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. hacktoberfest Issues targeting the hacktoberfest participants. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. sig/stack-guidance Categorizes an issue or PR as relevant to SIG Stack Guidance. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants