lack of support macos not supported

[ssbarnea]

I only understood much later that this tool works only on Linux as that was not obvious from its description.

$ thamos config         
2022-04-08 14:34:58,016 [61403] INFO     thamos: No configuration file found, creating one from a configuration template from a default template
2022-04-08 14:34:58,016 [61403] INFO     thamos.config: Discovering host runtime environment
2022-04-08 14:34:58,016 [61403] ERROR    thamos.discover: Failed to obtain CPU specific information: [Errno 2] No such file or directory: '/proc/cpuinfo'
Traceback (most recent call last):
  File "/Users/ssbarnea/.pyenv/versions/3.10.3/lib/python3.10/site-packages/thamos/discover.py", line 98, in discover_cpu
    with open(_PROC_CPU_INFO, "r") as cpu_info_file:
FileNotFoundError: [Errno 2] No such file or directory: '/proc/cpuinfo'
/bin/sh: edit: command not found
2022-04-08 14:34:58,044 [61403] ERROR    thamos: edit: Editing failed
FAIL: 1

The reality is that most people using python expect to see tools working on any POSIX system, including MacOS. If you happen not use have/use a mac, you can use BSD as close enough system to test against, as if you get it working on BSD, it will almost for sure work on MacOS.

If there is no desire to make it work on macos, at least Linux should be mentioned as part of the first sentence in product description, if not even the title itself. Also, adding a nice error message at cli would provide a better experience than a delayed tracedump.

[mayaCostantini]

/sig user-experience

[fridex]

We could catch the FileNotFoundError and produce a warning in these cases (and set CPU information to None). I'm not familiar with obtaining CPU info on macos (I don't have macos env to test this). This could be a good-enough solution to support calling advises on macos.

[fridex]

It looks like the config command works as expected - it reports that there was an error loading /proc/cpuinfo and keeps CPU information set to None. It looks like the following line is the culprint:

/bin/sh: edit: command not found

We use click.edit (see docs) to open the config file. However, it fails to find edit editor to open the configuration file.

[sesheta]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[codificat]

/remove-lifecycle stale

Suggested action plan:

• document what are the options to run thamos on MacOS (e.g. getting thamos advise for a linux-based stack)
• handle the situation and point to the doc above instead of throwing a traceback

[codificat]

/priority backlog
/triage accepted

[codificat]

/help
we could benefit from MacOS users contributions here

[sesheta]

@codificat:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help
we could benefit from MacOS users contributions here

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codificat]

/lifecycle frozen