sensible-editor: Editing failed in CI - that's expected

[TomasTomecek]

Bug description

We are running thamos in CI via yours pre-commit hook and getting this output:

/usr/bin/sensible-editor: 25: editor: not found
/usr/bin/sensible-editor: 28: nano: not found
/usr/bin/sensible-editor: 31: nano-tiny: not found
/usr/bin/sensible-editor: 34: vi: not found
Couldn't find an editor!
Set the $EDITOR environment variable to your desired editor.
2022-06-30 13:28:37,371 [123] ERROR    thamos: sensible-editor: Editing failed
              Runtime environment and configuration check results

Since this is running in CI, it's expected that $EDITOR is not available. Even pty may not be available. I'd suggest doing $editor magic only when it's needed.

Probably having an option for CI runs would be perfect.

Expected behavior

no such logs as described above

Environment information

pre-commit CI (probably ubuntu)

Additional context

packit/ogr#722
https://results.pre-commit.ci/run/github/161636700/1656595682.f1bfqPiYRaafQs0E09kC4g

[fridex]

If this issue is caused during thamos config, passing --no-interactive could be useful in these cases.

👋🏻

[mayaCostantini]

Yes, this will be fixed by thoth-station/thoth-pre-commit-hook#27 :)

[codificat]

Yes, this will be fixed by thoth-station/thoth-pre-commit-hook#27 :)

which is now merged, so
/close

thanks for the report and the fix!

[sesheta]

@codificat: Closing this issue.

In response to this:

Yes, this will be fixed by thoth-station/thoth-pre-commit-hook#27 :)

which is now merged, so
/close

thanks for the report and the fix!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.