Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to connect to thoth from pre-commit CI #1132

Closed
TomasTomecek opened this issue Jun 30, 2022 · 3 comments
Closed

Unable to connect to thoth from pre-commit CI #1132

TomasTomecek opened this issue Jun 30, 2022 · 3 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/stack-guidance Categorizes an issue or PR as relevant to SIG Stack Guidance.

Comments

@TomasTomecek
Copy link

Bug description

Latest CI run failed like this:

2022-06-30 13:28:40,465 [147] INFO     thamos.lib: Using requirements.txt file to manage dependencies located in '/code'
2022-06-30 13:28:40,472 [147] ERROR    thamos: HTTPSConnectionPool(host='khemenu.thoth-station.ninja', port=443): Max retries exceeded with url: /api/v1 (Caused by NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x7f862f3ac9d0>: Failed to establish a new connection: [Errno -3] Temporary failure in name resolution'))

Hard to tell what went wrong. But since network problems happen all the time, should we just reschedule or would it make sense to have some retry mechanism in thamos?

There is another "identical" run happening in Zuul but still hasn't started as of writing this.

Additional context

https://results.pre-commit.ci/run/github/161636700/1656595682.f1bfqPiYRaafQs0E09kC4g
packit/ogr#722

@TomasTomecek TomasTomecek added the kind/bug Categorizes issue or PR as related to a bug. label Jun 30, 2022
@mayaCostantini
Copy link
Contributor

This should normally be solved as TLS certificates were renewed for khemenu.thoth-station.ninja

@codificat
Copy link
Member

According to the error message, this was caused by a (temporary) DNS resolution problem, not related to the expired TLS certs.

The request here would be to add some (configurable?) retries to the API connection logic. To me, this sounds more like a feature than a bug though:

/kind feature
/remove-kind bug
/sig stack-guidance
/priority important-soon

Does that make sense to you?

@sesheta sesheta added kind/feature Categorizes issue or PR as related to a new feature. sig/stack-guidance Categorizes an issue or PR as relevant to SIG Stack Guidance. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed kind/bug Categorizes issue or PR as related to a bug. labels Jul 4, 2022
@TomasTomecek
Copy link
Author

We are not planning to run the hook in pre-commit CI right now so I am going to close as this won't be affecting us. All works well in Software Factory Zuul.

Feel free to reopen if you see value in this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/stack-guidance Categorizes an issue or PR as relevant to SIG Stack Guidance.
Projects
None yet
Development

No branches or pull requests

4 participants