Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a timeout to upload calls #65

Open
sslotsky opened this issue May 6, 2019 · 0 comments
Open

Add a timeout to upload calls #65

sslotsky opened this issue May 6, 2019 · 0 comments

Comments

@sslotsky
Copy link

sslotsky commented May 6, 2019

We are currently encountering an issue in Travis where some upload attempts are hanging.

https://www.traviscistatus.com/incidents/kyf149kl6bvp

The Travis build will abort after 10 minutes of not receiving output. Adding a timeout to the request.post call could be very helpful here. When I forked this library and added such a timeout, the plugin failed the build with this error:

ERROR in RollbarSourceMapPlugin: failed to upload 23.0a01a4daa723d7b93f81.js.map to Rollbar: ESOCKETTIMEDOUT

Having the plugin fail the build IMO is much better than having Travis wait 10 minutes and then abort. Not only do we get faster and more accurate feedback, but we can also use the ignoreErrors option and accept a partial success, allowing us to deploy without disabling the plugin completely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants