Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test fit results #50

Open
henrikef opened this issue Jan 19, 2021 · 1 comment
Open

Test fit results #50

henrikef opened this issue Jan 19, 2021 · 1 comment
Labels
enhancement good first issue help wanted no-issue-activity

Comments

@henrikef
Copy link
Contributor

Unless I'm missing something, test_geminga_paper seems to be the only one that actually compares the best-fit parameters to expected values. The other tests just run through the analysis and pass if there is no crash.
We should implement similar checks on the fit results for existing tests e.g. test_complete_analysis, and also something similar for the TS values etc.
@github-actions
Copy link

This issue has become stale. Is there an update? We will close in 14 days

@github-actions github-actions bot closed this as completed May 5, 2021
@henrikef henrikef reopened this May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue help wanted no-issue-activity
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@henrikef