-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up Issue with HAL #90
Labels
Comments
Before starting changing the code, we should keep track of our progresses. I suggest to set up a "catalog-style" example of one ROI where the convergence/speed is problematic, and work our way from there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Feature Request
During the HAWC collaboration meeting in Puerto Vallarta, it was noted that 3ML analysis was much slower with respect gammapy analysis. Quentin looked into possible bottleneck of the HAL code. Here is a summary (verbatim from him):
https://github.com/search?q=repo%3AthreeML/hawc_hal%20point_source_image&type=code
hawc_hal/hawc_hal/convolved_source/convolved_point_source.py
Line 59 in ce74038
fast
hawc_hal/hawc_hal/HAL.py
Line 209 in ce74038
hawc_hal/hawc_hal/HAL.py
Lines 215 to 217 in ce74038
hawc_hal/hawc_hal/psf_fast/psf_convolutor.py
Lines 24 to 25 in ce74038
hawc_hal/hawc_hal/HAL.py
Lines 999 to 1030 in ce74038
hawc_hal/hawc_hal/HAL.py
Lines 974 to 992 in ce74038
hawc_hal/hawc_hal/HAL.py
Line 966 in ce74038
hawc_hal/hawc_hal/HAL.py
Lines 1032 to 1045 in ce74038
hawc_hal/hawc_hal/HAL.py
Line 844 in ce74038
hawc_hal/hawc_hal/HAL.py
Line 972 in ce74038
because if only spectral parameters change it is not necessary to repeat the PSF convolution, one can rescale the cached value with a different weight in each energy bin. (edited)
hawc_hal/hawc_hal/convolved_source/convolved_extended_source.py
Line 133 in ce74038
The text was updated successfully, but these errors were encountered: