Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tfchain Billing logic #1560

Closed
3 tasks done
Tracked by #1565
sameh-farouk opened this issue Jul 16, 2024 · 3 comments
Closed
3 tasks done
Tracked by #1565

Refactor tfchain Billing logic #1560

sameh-farouk opened this issue Jul 16, 2024 · 3 comments
Assignees
Milestone

Comments

@xmonader xmonader added this to 3.15.x Jul 16, 2024
@xmonader xmonader moved this to Accepted in 3.15.x Jul 16, 2024
@xmonader xmonader added this to the 3.15 milestone Jul 16, 2024
@xmonader xmonader self-assigned this Jul 28, 2024
@xmonader xmonader moved this from Accepted to In Progress in 3.15.x Jul 28, 2024
@sameh-farouk sameh-farouk moved this from In Progress to Pending Review in 3.15.x Aug 14, 2024
@sameh-farouk sameh-farouk moved this from Pending Review to In Progress in 3.15.x Aug 14, 2024
@sameh-farouk
Copy link
Member Author

sameh-farouk commented Aug 14, 2024

Update:
The billing changes are now quite stable. I’ll begin working on complementary tasks such as adding new tests, updating documentation, and planning the necessary changes for the SDK.

I switched the PR to “ready for review” to indicate that no major changes are expected from this point forward.

@sameh-farouk
Copy link
Member Author

sameh-farouk commented Aug 19, 2024

Update:

  • Added some new tests and a new ADR document.
  • Resolved the comments on the PR.
  • I made some minor changes, mostly hardening and adjusting function names for consisntency.
  • I'm still awaiting feedback regarding whether a certified capacity should cost 25% more compared to a DIY capacity (It is one of the fixes implemented within the refactor.).

@sameh-farouk
Copy link
Member Author

sameh-farouk commented Aug 23, 2024

Update:

  • Resolved all comments on the PR.
  • Implemented additional test cases and ran an instance of a forked mainnet chain for several days to check for any inconsistent states.
  • I have implemented and tested a regular storage migration (as opposed to the lazy one we previously implemented) to make it easier to handle legacy contract locks in the SDKs.
  • Discovered a bug in the Polkadot-sdk v1.0.0 that we are currently based on, so we will probably push forward the upgrade to at least Polkadot-sdk v1.1.0 PR.
  • Although the pull request is ready, there is a new requirement regarding reward distribution that awaits confirmation. If accepted, it would extend the current work by maybe a day or two.

@sameh-farouk sameh-farouk mentioned this issue Aug 23, 2024
31 tasks
@xmonader xmonader moved this from In Progress to In Verification in 3.15.x Sep 4, 2024
@github-project-automation github-project-automation bot moved this from In Verification to Done in 3.15.x Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants