Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tBTC redemption UI support in the Threshold Dashboard #553

Closed
14 tasks done
Tracked by #3674
pdyraga opened this issue Jun 23, 2023 · 0 comments
Closed
14 tasks done
Tracked by #3674

tBTC redemption UI support in the Threshold Dashboard #553

pdyraga opened this issue Jun 23, 2023 · 0 comments
Assignees
@r-czajkowski

Comments

@pdyraga
Copy link
Member

pdyraga commented Jun 23, 2023 •
edited by r-czajkowski
Loading

This issue aggregates the Threshold Dashboard work needed to support tBTC redemptions.

Pull Requests
Beta Give feedback
  1. Find wallet for a redemption keep-network/tbtc-v2#630
    🔌 typescript
    r-czajkowski
  2. Redemption- select wallet #532
    📜 contract integration
    r-czajkowski
  3. Request redemption in one transaction keep-network/tbtc-v2#632
    🔌 typescript
    r-czajkowski
  4. Request redemption #537
    📜 contract integration
    r-czajkowski
  5. Redemption details page #523
    💎 components
    r-czajkowski
  6. Fetch redemption details #561
    💎 components 📜 contract integration
    r-czajkowski
  7. Get redemption params from url to fetch details #566
    💎 components
    r-czajkowski
  8. Improve find wallet for redemption logic keep-network/tbtc-v2#651
    🔌 typescript
    lukasz-zimnoch
  9. Convert script pub key to Bitcoin address #568
    r-czajkowski
  10. Enable tBTC v2 redemption feature flag #571
    💎 components
    r-czajkowski
  11. Display redemptions in my activity #570
    💎 components 📜 contract integration
    r-czajkowski
  12. Calculate Threshold Fee for redemption #569
    💎 components 📜 contract integration
    michalsmiarowski
  13. Render empty state on the Unmint page #572
    💎 components
    r-czajkowski
  14. Update copy on the Unmint page #575
    💎 components
    r-czajkowski
@pdyraga pdyraga mentioned this issue Jul 7, 2023
Closed
43 tasks
@lukasz-zimnoch lukasz-zimnoch mentioned this issue Jul 11, 2023
Merged
r-czajkowski added a commit to keep-network/tbtc-v2 that referenced this issue Jul 12, 2023
@r-czajkowski
Improve find wallet for redemption logic (#651)
ec34e17 
Refs: threshold-network/token-dashboard#553

Here we improve the logic of `findWalletForRedemption` function to
handle the corner case when a wallet's main UTXO known to the `Bridge`
was actually spent on Bitcoin but that change was not yet reflected to
the `Bridge`. So far, `findWalletForRedemption` relied on
`findAllUnspentTransactionOutputs` which does not return spent UTXOs so
determining the actual main UTXO was not possible in the aforementioned
corner case. Now, the `findWalletForRedemption` looks for recent wallet
transaction history on Bitcoin and tries to match the actual main UTXO
based on that. This change will allow submitting new redemption requests
without downtime, even if the target wallet is performing an action at
the moment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@r-czajkowski r-czajkowski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pdyraga @lukasz-zimnoch @r-czajkowski