Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArmVirtPkg: Report an error if NETWORK_TLS_ENABLE is TRUE on ARM #6479

Conversation

YangGangUEFI
Copy link
Contributor

Description

Refer to this commit, 32-bit ARM build will failed when NETWORK_TLS_ENABLE is TRUE.

This change report a error info directly then user can known the NETWORK_TLS_ENABLE usage.

And this change is also helpful for #6469

  • Breaking change?
    • Breaking change - Does this PR cause a break in build or boot behavior?
    • Examples: Does it add a new library class or move a module to a different repo.
  • Impacts security?
    • Security - Does this PR have a direct security impact?
    • Examples: Crypto algorithm change or buffer overflow fix.
  • Includes tests?
    • Tests - Does this PR include any explicit test code?
    • Examples: Unit tests or integration tests.

How This Was Tested

Use build -p ArmVirtPkg/ArmVirtQemu.dsc -a ARM -t GCC5 -D NETWORK_TLS_ENABLE, and it will give user a hint directly:

ArmVirtPkg/ArmVirtQemu.dsc(91): error FFFD: "NETWORK_TLS_ENABLE is not supported on ARM build!"

Integration Instructions

N/A

Signed-off-by: Yang Gang <yanggang@byosoft.com.cn>
@ardbiesheuvel ardbiesheuvel added the push Auto push patch series in PR if all checks pass label Nov 27, 2024
@mergify mergify bot merged commit 4928851 into tianocore:master Nov 27, 2024
126 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
push Auto push patch series in PR if all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants