Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

viridis type for discrete scales ? #3428

Closed
Ahobert opened this issue Jul 8, 2019 · 2 comments
Closed

viridis type for discrete scales ? #3428

Ahobert opened this issue Jul 8, 2019 · 2 comments
Labels
feature a feature request or enhancement scales 🐍

Comments

@Ahobert
Copy link
Contributor

Ahobert commented Jul 8, 2019

I noticed that scale_colour/fill_continuous has a type option specifying wheter to use gradient or viridis palettes. in order to enable color blindness friendly visualisation. Is there any particular reason why the same option is not (yet) implemented in scale_colour/fill_discrete or scale_colour/fill_hue, respectively?

@karawoo
Copy link
Member

karawoo commented Jul 8, 2019

I think the main reason is that we changed the default behavior for continuous color scales to use viridis, but also kept the ability to use the previous default (gradient). For discrete scales, viridis is less often a good choice unless the number of categories is very small. But you can still use it with discrete data using scale_colour_viridis_d()/scale_fill_viridis_d().

@paleolimbot paleolimbot added feature a feature request or enhancement scales 🐍 labels Jul 22, 2019
@teunbrand
Copy link
Collaborator

I think this inconsistency falls under the umbrella of #2851, so I'll close this here in favour of that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement scales 🐍
Projects
None yet
Development

No branches or pull requests

4 participants