Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation typo: ymin mentioned twice #5339

Closed
fkohrt opened this issue Jun 27, 2023 · 1 comment · Fixed by #5340
Closed

Documentation typo: ymin mentioned twice #5339

fkohrt opened this issue Jun 27, 2023 · 1 comment · Fixed by #5340
Labels
messages requests for improvements to error, warning, or feedback messages

Comments

@fkohrt
Copy link
Contributor

fkohrt commented Jun 27, 2023

The documentation currently says:

ggplot2/R/position-stack.R

Line 259 in 23508b3

"Stacking requires either the {.field ymin} {.emph and} {.field ymin} or the {.field y} aesthetics",

But probably the second field has to be ymax?
@teunbrand teunbrand added the messages requests for improvements to error, warning, or feedback messages label Jun 28, 2023
@teunbrand
Copy link
Collaborator

Yeah that looks like a typo to me and the second should be ymax. If you're interested in preparing a PR, it would be welcome. If not, we'll fix it at some point.

@fkohrt fkohrt mentioned this issue Jun 28, 2023
Merged
@teunbrand teunbrand mentioned this issue Jun 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
messages requests for improvements to error, warning, or feedback messages
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix typo fkohrt/ggplot2
2 participants
@fkohrt @teunbrand