Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geom_label doesn't allow for varying line types #5365

Open
FDylanT opened this issue Jul 26, 2023 · 4 comments
Open

geom_label doesn't allow for varying line types #5365

FDylanT opened this issue Jul 26, 2023 · 4 comments

Comments

@FDylanT
Copy link

FDylanT commented Jul 26, 2023

I would like to be able to manipulate the line type of the box produced by geom_label or annotate("label") (e.g. from a solid to a dashed line). At present, linetype isn't an accepted parameter in this geom, and produces an "ignoring unknown parameters" warning.

@teunbrand
Copy link
Collaborator

Is the goal here to have it as a mappable aesthetic or as a fixed parameter to pass to geom_label()?

@aphalo
Copy link
Contributor

aphalo commented Sep 14, 2023

Implementing this as a mapped aesthetic is dead simple. I can make a pull request if you like.

@teunbrand
Copy link
Collaborator

We'd be happy to review a PR implementing this. The non-obvious bit that comes to mind is that draw_key_label() needs to reflect the linetype as well.

@aphalo
Copy link
Contributor

aphalo commented Sep 15, 2023

o.k., I will give it a try next week. Thanks for the hint!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants