Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could position_dodge have a padding argument? #6001

Closed
davidhodge931 opened this issue Jul 16, 2024 · 3 comments
Closed

Could position_dodge have a padding argument? #6001

davidhodge931 opened this issue Jul 16, 2024 · 3 comments

Comments

@davidhodge931
Copy link

davidhodge931 commented Jul 16, 2024

Just as this is sometimes useful in position_dodge2, it could be useful at times in position_dodge

It would also be a way to have borders around dodged bars, and resolve issues with positioning noted in #5997

@davidhodge931 davidhodge931 changed the title Could position_dodge have a padding argument? Could position_dodge have a padding argument? Jul 16, 2024
@davidhodge931 davidhodge931 changed the title Could position_dodge have a padding argument? Could position_dodge have a padding argument? Jul 16, 2024
@teunbrand
Copy link
Collaborator

I think you can already specify padding using the width aesthetic and the position_dodge(width) parameter. Is there an example that is inconvenient where padding would alleviate some gnarlyness?

@davidhodge931
Copy link
Author

Ah I see, I didn't think of this! No, I can't think of an example that could not be achieved by using that method.

Still though, conceptually, if position_dodge and position_dodge2 are intended to be the same other than the grouping variable thing, then they should have the same arguments? So, either add padding to position_dodge or deprecate it from position_dodge2 if not needed. Likewise for reverse.

Feel free to close

@teunbrand
Copy link
Collaborator

So position_dodge2() needs a padding argument because it deals with variable-width data structures, whereas position_dodge() does not. For this reason, using width fixes the issue for position_dodge() but not position_dodge2().
The reverse argument has been added in #5932.

Feel free to close

Let's do this

@teunbrand teunbrand closed this as not planned Won't fix, can't repro, duplicate, stale Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants