-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regressions related to #5879 #6008
Comments
I think #5879 is a great addition! If you decide to keep this, I'd be happy to help submit PRs to other packages. Maybe helping moving the tests from tests that are quite sensitive and slow down ggplot2's process. expect_length(ggplot(), <specific length>
# better test
expect_s3_class(ggplot(), "ggplot")
Maybe ggplot2 could benefit from having a |
Thanks for the offer @olivroy! The |
This is an issue meant to track fallout from #5879 as determined through reverse dependency check in dbea0a6.
Issue #6003 was already identified and fixed in #6004.
Another issue is that
names(ggplot())
no longer contains thelabels
field. This trips up some tests in dependencies that expect thatlength(ggplot())
is some fixed value. This should be easy to fix.Another issue is that people sometimes test
expect_equal(plot$labels$var, "value")
. Asplot$labels
is no longer filled upon adding layers,plot$labels
is empty in many such cases and thus the tests fail. This affects >30 packages and is not straightforward to fix, so we'd need to decide wether to revert #5879 or ask maintainers to adapt their tests.The text was updated successfully, but these errors were encountered: