Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming of internal helper functions #6024

Open
teunbrand opened this issue Aug 2, 2024 · 0 comments · May be fixed by #6072
Open

Naming of internal helper functions #6024

teunbrand opened this issue Aug 2, 2024 · 0 comments · May be fixed by #6072

Comments

@teunbrand
Copy link
Collaborator

This dawned on me while preparing #6022, but the naming scheme for several (internal) functions is at times somewhat confusing.

Especially now that we're using the imported check_*() functions from {rlang}, it feels out of place to have ggplot2-native check_*() functions do something else than throwing errors/warnings. For example check_linewidth() returns data.

The inverse is also true, we have functions that are used solely for throwing errors/warnings, but don't have the check_*() prefix. An example of this is validate_element().

I understand these names precede the rlang checks, but it probably won't hurt to make the names more consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant