Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could the scale_*_steps* functions support applying the full range of colour provided? #6068

Open
davidhodge931 opened this issue Aug 31, 2024 · 1 comment

Comments

@davidhodge931
Copy link

davidhodge931 commented Aug 31, 2024

The scale_*_steps* functions currently do not apply the full range of colours to a plot.

See example below of scale_colour_binned, which applies the full range of the viridis colour palette compared to adding viridis colours to scale_colour_stepsn which does not.

Generally, you need as big a range of colour as possible when colouring a numeric variable.

Could the scale_*_steps* functions apply the full range of colour by default to the plot?

library(tidyverse)
library(palmerpenguins)
library(patchwork)

p1 <- penguins |>
  ggplot() +
  geom_point(aes(x = flipper_length_mm, y = body_mass_g, col = flipper_length_mm, )) +
  scale_colour_binned(type = "viridis") +
  labs(title = "binned")

p2 <- penguins |>
  ggplot() +
  geom_point(aes(x = flipper_length_mm, y = body_mass_g, col = flipper_length_mm, )) +
  scale_colour_stepsn(colours = viridis::viridis(9)) +
  labs(title = "stepsn")

p1 + p2
#> Warning: Removed 2 rows containing missing values or values outside the scale range
#> (`geom_point()`).
#> Removed 2 rows containing missing values or values outside the scale range
#> (`geom_point()`).

Created on 2024-09-01 with reprex v2.1.1

@teunbrand
Copy link
Collaborator

I've seen some SO posts around this, and I think having the option to do this is probably a good idea.
I don't think we should make it a default for backward compatibility reasons though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants