-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for Wireguard Threaded NAPI feature #1741
Conversation
✅ Deploy Preview succeeded!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for calico-docs-preview-next ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This enables Threaded NAPI for both the IPv4 and IPv6 WireGuard interfaces. | ||
|
||
</TabItem> | ||
<TabItem label="Manifest" value="Manifest-4"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need a separate tab for Operator and manual install. Even in manual install it's possible to use kubectl
to patch felixConfiguration.
@jrcichra Thanks for the documentation PR. You also need to make the same changes in the same file under |
Docs for feature PR: projectcalico/calico#9260
dc928c1
to
0721549
Compare
Once the cherry picks and enterprise PRs are merged, we need to copy the same content to the corresponding directories. |
We have about a dozen Wireguard-related Felix configuration parameters. Of those, only two are mentioned on this page, and both of them are required for the basic procedure to enable this feature. So my first question: Why include this more obscure parameter so prominently? Second: Would the warning be better placed (in a condensed form) in the parameter description in the configuration pages? We've recently changed the way we produce the Felix configuration docs. Changes to parameter descriptions need to be made in the codebase at projectcalico/calico. Perhaps see @fasaxc for details. |
I see. We can put this warning in the parameter description in the configuration pages instead, since it is an obscure feature like the rest of the tunables. |
@jrcichra You can probably add extra comments to the new config as comments. This way, the text will be populated in the docs automatically. Please tag me whenever you have the PR. |
I've made a PR on the main project here: projectcalico/calico#9440 |
Product Version(s):
Issue: projectcalico/calico#9260
Link to docs preview:
SME review:
DOCS review:
Additional information:
Merge checklist: