futures::Stream and futures::Sink instrumentation

[iGxnon]

I am building a network library, using a large number of Streams and Sinks to implement IO operations, and preparing to migrate from tokio tracing to minitrace.

I am wondering if support for Stream and Sink instrumentation can be added.

A related crate: https://crates.io/crates/tracing-futures

[andylokandy]

Yes,this is a good idea!

[iGxnon]

I'd like to help :D

[andylokandy]

Great to have you on board! Let's delve into the details. You can create a new crate named minitrace-futures, and then add SinkInSpan and StreamInSpan. It can be hosted either in this repository or in a new one of your own, depending on your preference.

[iGxnon]

It can be hosted either in this repository

Yes, I want to put it in this repo.

I implemented an initial version that meets the needs of my project while also providing more customization for some other scenarios.
Please give me some advice!

https://github.com/iGxnon/raknet-rs/blob/main/src/utils/minitrace.rs

A usecase in my project:

https://github.com/iGxnon/raknet-rs/blob/73e0da225fd1c6975a52c48497532571a497ac37/src/server/incoming/mod.rs#L38-L85

[andylokandy]

Great job! However, the MakeSpan appears to be overly specific.

Would you consider creating a pull request to include these changes in the repository?

[iGxnon]

Here #202

[andylokandy]

Closed by #202