Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize contexts #490

Merged
merged 7 commits into from
Nov 10, 2024
Merged

Optimize contexts #490

merged 7 commits into from
Nov 10, 2024

Conversation

timcassell
Copy link
Owner

@timcassell timcassell commented Nov 10, 2024 •
edited
Loading

  • Promise(<T>).ConfigureAwait(ContinuationOptions) consumes no memory if Promise.Config.AsyncFlowExecutionContextEnabled is disabled.
  • Unioned together some fields to reduce size of async Promise(<T>), async synchronization primitive promises, and Promise.ParallelFor*.

develop:

Type Pending Allocated Survived
AsyncAwait True - 648 B
ContinueWith True - 336 B

PR:

Type Pending Allocated Survived
AsyncAwait True - 624 B
ContinueWith True - 336 B

@timcassell
Optimize ConfigureAwait WIP.
de630e4
@timcassell
Merged reject container and continuation context into a shared field.
2b59076 
Inverted branch for context null check.
@timcassell
Fixed runtime class size increase.
02dbe0b
@timcassell
Clean up IPromiseAwareAwaiter.AwaitOnCompletedInternal.
61a9232 
Re-used `ContinuationContext` field in `AsyncSynchronizationPromiseBase<TResult>` to reduce memory.
@timcassell
Re-used ContinuationContext field in PromiseParallelForEach<> and…
ab4ccb0 
… `PromiseParallelForEachAsync<>` to reduce memory.
@timcassell timcassell added this to the v3.3.0 milestone Nov 10, 2024
@timcassell timcassell self-assigned this Nov 10, 2024
@timcassell timcassell merged commit 3292c95 into develop Nov 10, 2024
27 checks passed
@timcassell timcassell deleted the optimize-configureawait branch November 10, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@timcassell timcassell

Labels
performance
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
1 participant
@timcassell