From b97fca62e629a5e1e0312d28450ee5dee5bd8073 Mon Sep 17 00:00:00 2001
From: Tim Hendriks <tim-hendriks@hotmail.de>
Date: Fri, 2 Feb 2024 21:21:34 +0100
Subject: [PATCH] fix linting

---
 .github/workflows/ci.yml                       | 18 +++++++++---------
 examples/MultipleScenesSD/MultipleScenesSD.ino |  6 ++++--
 examples/SDAnimation/SDAnimation.ino           |  6 ++++--
 src/internal/ServoManager.h                    |  4 ++--
 4 files changed, 19 insertions(+), 15 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index bc31855..02b2f23 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -7,14 +7,14 @@ jobs:
     name: "Build"
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - name: Create library ZIP
         run: |
           mkdir BlenderServoAnimation
           cp -R src examples library.properties README.md LICENSE BlenderServoAnimation
           zip -r blender_servo_animation_arduino_library BlenderServoAnimation
       - name: Archive library ZIP
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: blender_servo_animation_arduino_library.zip
           path: |
@@ -38,14 +38,14 @@ jobs:
             WebSocketLiveMode,
           ]
     steps:
-      - uses: actions/checkout@v3
-      - uses: actions/cache@v3
+      - uses: actions/checkout@v4
+      - uses: actions/cache@v4
         with:
           path: |
             ~/.cache/pip
             ~/.platformio/.cache
           key: ${{ runner.os }}-pio
-      - uses: actions/setup-python@v4
+      - uses: actions/setup-python@v5
         with:
           python-version: "3.10"
       - name: Install PlatformIO Core
@@ -58,7 +58,7 @@ jobs:
     name: "Lint"
     runs-on: ubuntu-22.04
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - name: Lint with clang-format
         uses: jidicula/clang-format-action@v4.10.2
         with:
@@ -71,14 +71,14 @@ jobs:
     name: "Test"
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - name: Cache PlatformIO directory
-        uses: actions/cache@v3
+        uses: actions/cache@v4
         with:
           path: /home/runner/.platformio
           key: platformio-dir
       - name: Set up Python 3.10
-        uses: actions/setup-python@v4
+        uses: actions/setup-python@v5
         with:
           python-version: "3.10"
           cache: "pip"
diff --git a/examples/MultipleScenesSD/MultipleScenesSD.ino b/examples/MultipleScenesSD/MultipleScenesSD.ino
index e53c82c..4ca93b7 100644
--- a/examples/MultipleScenesSD/MultipleScenesSD.ino
+++ b/examples/MultipleScenesSD/MultipleScenesSD.ino
@@ -65,13 +65,15 @@ BlenderServoAnimation::Animation animation;
 
 void setup() {
   Serial.begin(9600);
-  while (!Serial);
+  while (!Serial) {
+  };
 
   Serial.println("Initializing SD card...");
 
   if (!SD.begin(CS_PIN)) {
     Serial.println("Initialization failed!");
-    while (true);
+    while (true) {
+    };
   }
   Serial.println("Initialization done.");
 
diff --git a/examples/SDAnimation/SDAnimation.ino b/examples/SDAnimation/SDAnimation.ino
index 9e646e5..c550cc4 100644
--- a/examples/SDAnimation/SDAnimation.ino
+++ b/examples/SDAnimation/SDAnimation.ino
@@ -41,13 +41,15 @@ BlenderServoAnimation::Animation animation;
 
 void setup() {
   Serial.begin(9600);
-  while (!Serial);
+  while (!Serial) {
+  };
 
   Serial.println("Initializing SD card...");
 
   if (!SD.begin(CS_PIN)) {
     Serial.println("Initialization failed!");
-    while (true);
+    while (true) {
+    };
   }
   Serial.println("Initialization done.");
 
diff --git a/src/internal/ServoManager.h b/src/internal/ServoManager.h
index 353a8c5..2da4c24 100644
--- a/src/internal/ServoManager.h
+++ b/src/internal/ServoManager.h
@@ -34,8 +34,8 @@ class ServoManager {
 
   void handleCommand();
 
-  Servo* addServo(byte id);
-  Servo* getServo(byte id);
+  Servo *addServo(byte id);
+  Servo *getServo(byte id);
 };
 
 } // namespace BlenderServoAnimation