Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option for maximum draw count & rate limiting #2

Open
s5bug opened this issue Jun 30, 2020 · 1 comment
Open

Option for maximum draw count & rate limiting #2

s5bug opened this issue Jun 30, 2020 · 1 comment

Comments

@s5bug
Copy link

s5bug commented Jun 30, 2020

I just wanted to display an image on a PixelFlut server that can't handle pixelpwnr's output of:

image

1 MiB/s, and can actually only handle about 5 draws per second. I didn't know that pixelpwnr sends images infinitely, which filled up the drawing queue of the PixelFlut server, and now it won't stop drawing the same pixels over and over.

Possibility of an option for maximum speed/maximum draws?

@timvisee
Copy link
Owner

timvisee commented Jun 30, 2020

I think a maximum speed/rate limiting may be tricky to implement, and I do not have plans for that. Adding a 'single drawing' option is definitely possible.

I'm currently not actively working on this due to other work, so I'll leave this open for a later time. Feel free to submit a PR for this.

Regarding the maximum speed; maybe something like this can be achieved by limiting the write buffer size, but I'm not sure.

Edit: now that I think of it, a configurable delay between draws should also be easily implementable, which would provide some form of rate limiting.

@timvisee timvisee changed the title HELP! I PWND TOO HARD! (Option for maximum number of draws/maximum draw speed?) Option for maximum draw count & rate limiting Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants