Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kitty base-16 color template doesn't match specs #3

Closed
psynyde opened this issue Oct 1, 2024 · 2 comments
Closed

Kitty base-16 color template doesn't match specs #3

psynyde opened this issue Oct 1, 2024 · 2 comments
Assignees

Comments

@psynyde
Copy link

psynyde commented Oct 1, 2024

Hi,
I went through tinted-theming base-16 style guide and kitty color table and looks like bright colors from template/base16.mustache doesn't follow the specs.
for example:

color8 #{{base03-hex}}
color9 #{{base09-hex}} -- orange instead of bright red
color10 #{{base01-hex}} -- black instead of light green
color11 #{{base02-hex}} -- light black instead of yellow
color12 #{{base04-hex}} -- gray instead of blue
color13 #{{base06-hex}} -- foreground (white) instead of magenta
color14 #{{base0F-hex}} -- dark red instead of cyan
color15 #{{base07-hex}}

I believe the issue in danth/stylix#567 is also caused by this.

@JamyGolden
Copy link
Member

Thanks for the issue. I've just created a PR to fix this: #4

I'll merge it in a day or so if there is no discussion around it

@JamyGolden
Copy link
Member

Just merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants