Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug report] Comments are non-italic for Treesitter highlight groups #84

Closed
floriankessler opened this issue Sep 22, 2024 · 3 comments
Closed

[Bug report] Comments are non-italic for Treesitter highlight groups #84

floriankessler opened this issue Sep 22, 2024 · 3 comments
Assignees
@belak
Labels
bug Something isn't working

Comments

@floriankessler
Copy link

Comments are non-italic for Treesitter highlight groups
https://github.com/tinted-theming/base16-vim/blob/8a2190069b1c91c104e1de5ec57431d71472be8e/templates/default.mustache#L306

while they are for standard syntax.
https://github.com/tinted-theming/base16-vim/blob/8a2190069b1c91c104e1de5ec57431d71472be8e/templates/default.mustache#L259

I'd expect comments to be shown using italics for TS-based setups, too
@floriankessler floriankessler added the bug Something isn't working label Sep 22, 2024
@belak belak closed this as completed in 7ba1012 Sep 22, 2024
@belak
Copy link
Member

belak commented Sep 22, 2024

Thanks for the report! That makes sense to me. Should be fixed in 7ba1012. I'll trigger a manual rebuild as well.

@belak
Copy link
Member

belak commented Sep 22, 2024

Should be fixed in main. The built commit is dfc1d89. Thanks again for the report!

@floriankessler
Copy link
Author

Works for me, now. Thanks for all your work!

craigfurman added a commit to craigfurman/ansible-home that referenced this issue Oct 4, 2024
@craigfurman
Fix kitty fonts
eaf97fc 
Hoo boy, a few unrelated fixes are in this simple change. First, remove
the italic and bold italic fallback to Menlo (since inconsolata doesn't
have italic support). In practice I never saw this - my vim colorscheme
was not setting italics for treesitter comments until
tinted-theming/tinted-vim#84. Once that issue
was solved, I unexpectedly started seeing line height conflicts due to
my terminal's Menlo fallback (https://xkcd.com/1172/).

I don't actually want italics in vim, so I'll just remove this fallback
in my kitty config instead.

Secondly, use inconsolata nerd font in kitty. I thought I was happy with
kitty's fallback to symbols-nerd-font to get symbols for NvimTree, but
this caused another size conflict.

Finally, don't specify regular/bold/etc, let kitty figure that out. I
confirmed with `kitty --debug-font-fallback` that its falling back on
regular for italics.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@belak belak

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@belak @JamyGolden @GordianDziwis @floriankessler