Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for client-go credential plugins #108

Open
tintoy opened this issue Nov 9, 2019 · 2 comments
Open

Support for client-go credential plugins #108

tintoy opened this issue Nov 9, 2019 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@tintoy
Copy link
Owner

tintoy commented Nov 9, 2019

Docs here.

See felixfbecker/PSKubectl#54 for further details.

@tintoy tintoy added the enhancement New feature or request label Nov 9, 2019
@tintoy tintoy self-assigned this Nov 9, 2019
@tintoy
Copy link
Owner Author

tintoy commented Feb 8, 2020

Ugh - this is ugly; the old-style credential commands took a list of arguments but the new client-go credential plugins (i.e. "exec") take a simple string containing all arguments (presumably in platform-specific format).

This means we need to support BOTH a list of arguments AND a simple string containing all arguments (and propagate this all the way through to System.Diagnostics.Process) because platform-specific quoting and escaping of command arguments is a bit of a nightmare).

@felixfbecker
Copy link
Collaborator

Here's an idea: Could you deserialize the property directly into a System.Diagnostics.ProcessStartInfo? It has both ArgumentList and Arguments (string), which you could set respectively. From there it would be easy to directly spawn the process by passing the ProcessStartInfo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants