Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stub syscall.Environ and syscall. SysProcAttr so stdlib tests using internal/testenv can build #2186

Closed
dgryski opened this issue Oct 16, 2021 · 5 comments
Labels
enhancement New feature or request

Comments

@dgryski
Copy link
Member

dgryski commented Oct 16, 2021

No description provided.

@dgryski
Copy link
Member Author

dgryski commented Oct 16, 2021

Actually, it's not clear this is necessarily the lowest hanging fruit to get more stdlib tests passing out of the box. Might be worth poking around to a bit to what the easiest way forward is.

@aykevl
Copy link
Member

aykevl commented Oct 17, 2021

I think implementing syscall.Environ wouldn't be very difficult (see syscall.Getenv for example), so I would prefer if it was fully implemented from the start.

@deadprogram deadprogram added the enhancement New feature or request label Oct 30, 2021
@dgryski
Copy link
Member Author

dgryski commented Nov 10, 2021

Building our own internal/testenv might make more sense. It's a pretty small package that we can easily tailor to testing needs. However, since many of the tests look for particular features and then call t.Skip() (which isn't yet supported), the runtime behaviour of the tests may not be what we expect if even they can now build.

@dkegel-fastly
Copy link
Contributor

This would help github.com/getlantern/golog build. (Along with go-stack/stack#31.)

Given that I ran into it really quickly in my little fishing expedition, this seems high value.

@dgryski
Copy link
Member Author

dgryski commented Dec 8, 2021

This was handled in #2268

@dkegel-fastly If you're still having trouble with getlantern/golog or go-stack/stack, let's open new bugs with what's actually missing.

@dgryski dgryski closed this as completed Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants