Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Statement and Expression node parent classes #33

Open
barnjamin opened this issue Dec 6, 2022 · 0 comments
Open

Refactor Statement and Expression node parent classes #33

barnjamin opened this issue Dec 6, 2022 · 0 comments

Comments

@barnjamin
Copy link
Contributor

Since Statements and Expressions both inherit from BaseNode some issues arise in accessing attributes that are not defined in one or the other. We can change the inheritance structure to split the different Node types for better type information and prevent issues with inferring attribute availability.

See this comment for more: #27 (review)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@barnjamin