Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please create a new npm release #183

Open
fiznool opened this issue Jul 2, 2014 · 12 comments
Open

Please create a new npm release #183

fiznool opened this issue Jul 2, 2014 · 12 comments

Comments

@fiznool
Copy link

fiznool commented Jul 2, 2014

v1.0.1 to include the fix for #130

@parkr
Copy link

parkr commented Sep 16, 2014

@visionmedia You still maintaining this project?

@mde
Copy link
Collaborator

mde commented Sep 16, 2014

@parkr I'm ostensibly maintaining this, although I haven't had a chance to do much with it yet. I'll make sure I can publish to NPM and try to get a new release by the end of the week. Thanks for your patience.

@parkr
Copy link

parkr commented Sep 16, 2014

No problem, @mde! Just curious. Thanks for the time you can contribute to the project. 😄

@silverbucket
Copy link

ping

@mde
Copy link
Collaborator

mde commented Dec 25, 2014

Pong. :) It's the holidays! I'm looking at this PR: #156 and trying to get tests passing before I try to push.

@mde
Copy link
Collaborator

mde commented Jan 2, 2015

@parkr and @silverbucket I am putting together a v2.0 here: https://github.com/mde/ejs It uses a preexisting implementation I bundled with Geddy, and I believe I've got feature parity (except for filters, which I'd like to deprecate). Could y'all give it a quick look and let me know what you think? If it's kosher, I'll push it out to NPM in the next day or so.

@parkr
Copy link

parkr commented Jan 2, 2015

@mde do you have a changelog?

@mde
Copy link
Collaborator

mde commented Jan 3, 2015

@parkr Good call: https://github.com/mde/ejs/blob/master/CHANGELOG.md

There are backward-compat shims for the change to separate data/options, and for the include function. No changes to existing code should be necessary for those. The only breaking change is the removal of filters.

@parkr
Copy link

parkr commented Jan 3, 2015

👍

@little-big-h
Copy link

What is the rationale behind removing filters in this release? I was using them extensively and was quite happy with them?

@mde
Copy link
Collaborator

mde commented Jan 4, 2015

Filters are not an EJS-specific feature (none of the other implementations have it), and can be implemented just as easily using external helper functions. It's just JavaScript, and you can run whatever functions you want inside your templates.

I want to keep the core of EJS small and limited to plain JavaScript. If you really depend on filters, you can continue to use them with v1 for now.

Having said that though, I'd be interested in providing an easy way for you to plug filters in (maybe with custom tags?), and I'd love to work with somebody to add that functionality.

@tj
Copy link
Owner

tj commented Jan 4, 2015

+1 for removal of filters, kinda weird, not sure why I added them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants