Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TFLOPS is off by a factor of 2 in conv_benchmark.py? #20

Open
geohot opened this issue Feb 12, 2023 · 0 comments
Open

TFLOPS is off by a factor of 2 in conv_benchmark.py? #20

geohot opened this issue Feb 12, 2023 · 0 comments

Comments

@geohot
Copy link

geohot commented Feb 12, 2023 •
edited
Loading

On line 20, you are computing the TFLOPS as such:
conv_flops = MN * MN * CK * CK * HW * HW

Wouldn't it actually be 2x this since each of those points is an add and a mul? I see the "*2" in tflops_sweep.py

Brings the computed speed from 4.8 TFLOPS to 9.6 TFLOPS, a lot closer to the 10.4 theoretical max.

(though since it's 3x3, it might be a Winograd conv)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@geohot