Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current theme changes with delay #347

Open
4 tasks done
artiekra opened this issue Aug 1, 2024 · 1 comment
Open
4 tasks done

Current theme changes with delay #347

artiekra opened this issue Aug 1, 2024 · 1 comment
Labels

Comments

@artiekra
Copy link

artiekra commented Aug 1, 2024

Checklist

  • I am able to reproduce the bug with the latest debug version (Android, Linux, Windows)
  • I've checked that there is no open or closed issue about this bug.
  • This issue contains only one bug.
  • The title of this issue accurately describes the bug.

Steps to reproduce

  1. Go into the settings menu
  2. Open the "Theming" section of the settings ("Current theme" is whats gonna be changing)
  3. The default is "System theme" (1/14); switching from it to "Catppuccin Mocha (mauve)" (2/14) and vice-versa seems fine, but a bit laggy.
  4. Switch from "Catppuccin Mocha (mauve)" (2/14) to any other theme from the next ones.

Expected behavior

The theme should immidiately switch to the selected one; the number (n/14) should be updated, as well as the theme name in the selection menu.

Actual behavior

Nothing happens after button presses. To apply the theme correctly, you have to exit the theming section, and enter it again.

Screenshots / recordings

spmp1.mp4

Logs

None

SpMp version

SpMp non-release build on 33d7f79 and API version 2 (spmp-0.4.0-beta1.apk-debug.apk)

SpMp platform

Android

OS version

Android 9; EMUI 9.1.0

Additional information

Doesn't happen on release build v0.3.2

@artiekra artiekra added the Bug label Aug 1, 2024
@toasterofbread
Copy link
Owner

This will be fixed when #345 is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants