Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqm-cbi.lua sets fq_codel as default but .org states Cake is default queue discipline #130

Open
spm1001 opened this issue Dec 31, 2020 · 4 comments

Comments

@spm1001
Copy link

spm1001 commented Dec 31, 2020

This sets fq_codel as default, but documentation on OpenWrt.org here and here states Cake is default

Similarly 'simple.qos' is given as default setup script in gui but piece_of_cake in docs

@tohojo
Copy link
Owner

tohojo commented Dec 31, 2020 via email

@hnyman
Copy link

hnyman commented Dec 31, 2020

documentation on OpenWrt.org

Better reference might be the default config file actually shipped...
https://github.com/tohojo/sqm-scripts/blob/master/platform/openwrt/sqm-uci#L7-L8

The LuCI default is only what GUI thinks as the default if there is no value in the config file.

@hnyman
Copy link

hnyman commented Dec 31, 2020

@tohojo

Hmmm...
Is it intentional, that actually we are shipping the August 2019 version of SQM in Openwrt?

https://github.com/openwrt/packages/blob/master/net/sqm-scripts/Makefile

PKG_NAME:=sqm-scripts
PKG_SOURCE_VERSION:=ab763cba8b1516b3afa99760e0ca884f8b8d93b8
PKG_VERSION:=1.4.0
PKG_RELEASE:=9

In ab763cb
the default is still simple / fq_codel

You have changed it locally here later, but in the OpenWrt packages we still use the version ab763cb
All later changes are ignored, including the change of default to cake.

(I just checked a build that I compiled a few minutes ago, and simple/fq_codel is the default config there)

Last actual SQM "upstream code" version bump was done by you in Sep 2019 with commit
openwrt/packages@1126368

@tohojo
Copy link
Owner

tohojo commented Dec 31, 2020

Heh, no, that was not intentional - will fix that as well! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants