Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Record ExpectedTask creation location in console-subscriber tests #461

Open
hds opened this issue Sep 6, 2023 · 0 comments
Open

Record ExpectedTask creation location in console-subscriber tests #461

hds opened this issue Sep 6, 2023 · 0 comments
Labels
S-feature Severity: feature. This is adding a new feature.

Comments

@hds
Copy link
Collaborator

hds commented Sep 6, 2023 •
edited
Loading

What problem are you trying to solve?

When a test asserts on mulitple expected tasks, it may not be clear which one fails in the case of a failure.

How should the problem be solved?

Record the panic location when creating the ExpectedTask and put #[track_caller] on the constructor.
@hds hds added the S-feature Severity: feature. This is adding a new feature. label Sep 6, 2023
@hds hds mentioned this issue Sep 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
S-feature Severity: feature. This is adding a new feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hds