+
@@ -3483,7 +3495,7 @@
100.0 % covered
- # For example, we don't want things like:
+ # For example, we don't want things like:
@@ -3525,586 +3537,652 @@ 100.0 % covered
1
- context 'returns matching strings' do
+ def self.examples_raise_illegal_syntax_error(*regexps)
1
- context "for basic repeaters" do
+ regexps.each do |regexp|
-
+
+ 4
+ it do
+
+
+
+ 8
- examples_exist_and_match(
+ expect{regexp.examples}.to raise_error RegexpExamples::IllegalSyntaxError
-
+
+
+
+ end
+
+
+
+
+
+ end
+
+
+
+
+
+ end
+
+
+
+
+
+ context 'returns matching strings' do
+
+
+
+ 1
+
+ context "for basic repeaters" do
+
+
+
+ 1
+
+ examples_exist_and_match(
+
+
+
+
+
/a/,
-
+
/a*/,
-
+
/a+/,
-
+
/a?/,
-
+
/a{1}/,
-
+
/a{1,}/,
-
+
/a{1,2}/
-
+
)
-
+
end
-
+
context "for basic groups" do
-
-
+
+ 1
examples_exist_and_match(
-
- 1
+
+
/[a]/,
-
+
/(a)/,
-
+
/a|b/,
-
+
/./
-
+
)
-
+
end
-
+
context "for complex char groups (square brackets)" do
-
-
+
+ 1
examples_exist_and_match(
-
- 1
+
+
/[abc]/,
-
+
/[a-c]/,
-
+
/[abc-e]/,
-
+
/[^a-zA-Z]/,
-
+
/[\w]/,
-
+
/[]]/, # TODO: How to suppress annoying warnings on this test?
-
+
/[\]]/,
-
+
/[\\]/,
-
+
/[\\\]]/,
-
+
/[\n-\r]/,
-
+
/[\-]/,
-
+
/[%-+]/ # This regex is "supposed to" match some surprising things!!!
-
+
)
-
+
end
-
+
context "for complex multi groups" do
-
-
+
+ 1
examples_exist_and_match(
-
- 1
+
+
/(normal)/,
-
+
/(?:nocapture)/,
-
+
/(?<name>namedgroup)/,
-
+
/(?<name>namedgroup) \k<name>/
-
+
)
-
-
-
- # TODO: These are not yet implemented
-
-
-
-
-
- # (expect to raise exception)
-
-
-
-
-
- # /(?=lookahead)/,
-
-
-
-
-
- # /(?!neglookahead)/,
-
-
-
-
-
- # /(?<=lookbehind)/,
-
-
-
-
-
- # /(?<!neglookbehind)/,
-
-
-
+
end
-
+
context "for escaped characters" do
-
-
+
+ 1
examples_exist_and_match(
-
- 1
+
+
/\w/,
-
+
/\W/,
-
+
/\s/,
-
+
/\S/,
-
+
/\d/,
-
+
/\D/,
-
+
/\h/,
-
+
/\H/,
-
+
/\t/,
-
+
/\n/,
-
+
/\f/,
-
+
/\a/,
-
+
/\v/,
-
+
/\e/
-
+
)
-
+
end
-
+
context "for backreferences" do
-
-
+
+ 1
examples_exist_and_match(
-
- 1
+
+
/(repeat) \1/,
-
+
/(ref1) (ref2) \1 \2/,
-
+
/((ref2)ref1) \1 \2/,
-
+
/((ref1and2)) \1 \2/,
-
+
/(one)(two)(three)(four)(five)(six)(seven)(eight)(nine)(ten) \10\9\8\7\6\5\4\3\2\1/,
-
+
/(a?(b?(c?(d?(e?)))))/
-
+
)
-
+
end
-
+
context "for complex patterns" do
-
+
# Longer combinations of the above
-
-
+
+ 1
examples_exist_and_match(
-
- 1
+
+
/https?:\/\/(www\.)github\.com/,
-
+
/(I(N(C(E(P(T(I(O(N)))))))))*/,
-
+
/[\w]{1}/,
-
+
/((a?b*c+)) \1/,
-
+
/((a?b*c+)?) \1/,
-
+
/a|b|c|d/,
-
+
/a+|b*|c?/
-
+
)
-
+
end
-
+
+
+
+ context "for illegal syntax" do
+
+
+
+ 1
+
+ examples_raise_illegal_syntax_error(
+
+
+
+
+
+ /(?=lookahead)/,
+
+
+
+
+
+ /(?!neglookahead)/,
+
+
+
+
+
+ /(?<=lookbehind)/,
+
+
+
+
+
+ /(?<!neglookbehind)/
+
+
+
+
+
+ )
+
+
+
+
+
+ end
+
+
+
end
-
+
end
diff --git a/lib/regexp-examples/exceptions.rb b/lib/regexp-examples/exceptions.rb
new file mode 100644
index 0000000..78c779e
--- /dev/null
+++ b/lib/regexp-examples/exceptions.rb
@@ -0,0 +1,5 @@
+module RegexpExamples
+ class Error < StandardError; end
+ class UnsupportedSyntaxError < Error; end
+ class IllegalSyntaxError < Error; end
+end
diff --git a/lib/regexp-examples/parser.rb b/lib/regexp-examples/parser.rb
index bd17a5c..5432faa 100644
--- a/lib/regexp-examples/parser.rb
+++ b/lib/regexp-examples/parser.rb
@@ -92,9 +92,9 @@ def parse_multi_group
@current_position += 2
group_id = nil
when %w(! =).include?(match[2]) # e.g. /(?=lookahead)/, /(?!neglookahead)/
- # TODO: Raise exception
+ raise IllegalSyntaxError, "Lookaheads are not regular; cannot generate examples"
when %w(! =).include?(match[3]) # e.g. /(?<=lookbehind)/, /(?namedgroup)/
@current_position += (match[3].length + 3)
group_id = match[3]
diff --git a/spec/regexp-examples_spec.rb b/spec/regexp-examples_spec.rb
index 9626f32..c68e889 100644
--- a/spec/regexp-examples_spec.rb
+++ b/spec/regexp-examples_spec.rb
@@ -13,6 +13,14 @@ def self.examples_exist_and_match(*regexps)
end
end
+ def self.examples_raise_illegal_syntax_error(*regexps)
+ regexps.each do |regexp|
+ it do
+ expect{regexp.examples}.to raise_error RegexpExamples::IllegalSyntaxError
+ end
+ end
+ end
+
context 'returns matching strings' do
context "for basic repeaters" do
examples_exist_and_match(
@@ -59,12 +67,6 @@ def self.examples_exist_and_match(*regexps)
/(?namedgroup)/,
/(?namedgroup) \k/
)
- # TODO: These are not yet implemented
- # (expect to raise exception)
-# /(?=lookahead)/,
-# /(?!neglookahead)/,
-# /(?<=lookbehind)/,
-# /(?