Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

question / feature request: allow recording in full color range #264

Open
tari3x opened this issue Nov 28, 2023 · 7 comments
Open

question / feature request: allow recording in full color range #264

tari3x opened this issue Nov 28, 2023 · 7 comments

Comments

@tari3x
Copy link

tari3x commented Nov 28, 2023

Currently the color range of the recordings seems to be limited:

ffprobe -f lavfi movie="capture.avi",signalstats -show_entries frame_tags=lavfi.signalstats.YMAX,lavfi.signalstats.YMIN
...
[FRAME]
TAG:lavfi.signalstats.YMIN=16
TAG:lavfi.signalstats.YMAX=235
[/FRAME]

I suspect this is expected since a real amiga would output to a TV set which has limited range. But just in case I'm confused here's a feature request - please allow to record in full color range.

Afaik utvideo + avi don't have anywhere to mark the video as full range, so it would need to be mkv.

@luvwagn
Copy link

luvwagn commented Nov 28, 2023

Could also be done into an MP4 container, with AVC/H264 as the encoding type?

@tonioni
Copy link
Owner

tonioni commented Dec 3, 2023

AVI recording was done by someone else long, long, long time ago and I am not interested in rewriting it to use some modern method (video recording is probably my lowest priority feature ever..). Perhaps if there is some really good license compatible open source example somewhere.

@luvwagn
Copy link

luvwagn commented Dec 3, 2023 via email

@tari3x
Copy link
Author

tari3x commented Dec 5, 2023

video recording is probably my lowest priority feature ever..

That's sad actually - I suspect recording amiga demos is a rather sizeable use case.

@tonioni
Copy link
Owner

tonioni commented Dec 26, 2023

I don't think it is that simple, for example does it support uncompressed? Thats very nice feature of AVI stuff, you can select uncompressed (can easily test if recording is exactly right) and IMHO it is better to record it in some non-lossy format (AVI has non-lossy formats which someone really wants to have), edit the file and then convert it to whatever format you want.

Anyway, as I said, I need example sources that is proven working, that includes CODEC selection GUI. I am not interested in reading some API docs that usually always suck and assume you already know what are you doing :)
(It does not need to be emulator, just some program that records something)

@johnnovak
Copy link

I don't think it is that simple, for example does it support uncompressed? Thats very nice feature of AVI stuff, you can select uncompressed (can easily test if recording is exactly right) and IMHO it is better to record it in some non-lossy format (AVI has non-lossy formats which someone really wants to have), edit the file and then convert it to whatever format you want.

Anyway, as I said, I need example sources that is proven working, that includes CODEC selection GUI. I am not interested in reading some API docs that usually always suck and assume you already know what are you doing :) (It does not need to be emulator, just some program that records something)

Video encoding is a huge rabbit hole agreed. We're experiencing that in DOSBox Staging now 😅 Lossless is the best option, then people can encode that however they like 🤷🏻 ...unless you want to mess around with vendor-specific APIs to add hardware accelerated encoding support, which is nice, but fiddly.

@luvwagn
Copy link

luvwagn commented Dec 29, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants