Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent and unclear use of pointers in vaultrecord #6

Open
hielkehoeve opened this issue Jan 28, 2022 · 0 comments
Open

Inconsistent and unclear use of pointers in vaultrecord #6

hielkehoeve opened this issue Jan 28, 2022 · 0 comments

Comments

@hielkehoeve
Copy link
Contributor

With the use of pointers for some fields in vaultrecord it is unclear what values mean when no value is set or a value is an empty value (eg, "" or 0). For example, is the password not set when the password = ""? Does only a nil value mean it is not set?

  • Remove pointers in all model structs except for situations of large values (eg byte[])
  • Add functions which assist in checking whether values are set
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant