Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"/system/bin/magisk" should not bind-mount when "Superuser Access" is disabled #8652

Open
ccaapton opened this issue Dec 20, 2024 · 4 comments

Comments

@ccaapton
Copy link

ccaapton commented Dec 20, 2024

Device: redmi k20(davinci)
Android version: 14
Magisk version name: 47cc532
Magisk version code: 28101

When I only need systemless hosts, I do not need to give access to any third party apps. So I set "Superuser Access" to "disabled", and zygisk disabled. I expect that /system/bin/magisk will not mount at all, as this is only for convenience to 3rd party apps.

But the actual result is that it is mounted there.

Is it possible to not mount '/system/bin/' at all if "Superuser Access=disabled"?

@ccaapton
Copy link
Author

As for the communication between daemon and magisk_app, maybe we can implement some kind of inversion of control: instead of app connect to /debug_ramdisk/.magisk/device/socket, app can listen for a Unix socket under private directory, and magisk daemon connect to it.

@jdjrjjde
Copy link

I have a source code from this project, can you build the serverless apk file for me? Thank you
ApkProtector.zip
k2

@jdjrjjde
Copy link

@topjohnwu @vvb2060 @HuskyDG

@ccaapton
Copy link
Author

As for the communication between daemon and magisk_app, maybe we can implement some kind of inversion of control: instead of app connect to /debug_ramdisk/.magisk/device/socket, app can listen for a Unix socket under private directory, and magisk daemon connect to it.

Alternatively, magisk could implement some kind of pcap on localhost udp port-range, similar to fwknop. User app can send handshake information to a port range, then magisk_daemon can answer back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants