You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We can't be sure that readlink /proc/1/ns/mnt command will return content. If the standard output has no content (maybe in error output, or nothing at all), then readLine() will block.
" -t, --target PID PID to take mount namespace from\n"
MagiskSU now supports setns, this check has lost its meaning. I don't think anyone really cares about state other than root, so this check can be removed. libsu should do as little as possible and leave any additional requirements to the developers themselves.
The text was updated successfully, but these errors were encountered:
libsu/core/src/main/java/com/topjohnwu/superuser/internal/ShellImpl.java
Lines 164 to 166 in c9f1a6e
We can't be sure that
readlink /proc/1/ns/mnt
command will return content. If the standard output has no content (maybe in error output, or nothing at all), thenreadLine()
will block.https://github.com/topjohnwu/Magisk/blob/4856da1584c16f5c7387efcefe255c21a1978233/native/src/core/su/su.cpp#L38
MagiskSU now supports setns, this check has lost its meaning. I don't think anyone really cares about state other than root, so this check can be removed. libsu should do as little as possible and leave any additional requirements to the developers themselves.
The text was updated successfully, but these errors were encountered: