You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The "high level" bug is that inputs don't affect the Tool.lang correctly -- Tool.lang is determined only by the presence of an -x flag or the tool class itself, meaning that blight.CC.lang will always report Lang.C unless -x c++ is passed. This manifests particularly as the wrong lang value for assembly inputs: cc foo.sought to report Lang.Asm (which doesn't exist yet), but reports Lang.C instead.
The "low level" bug is that Tool.lang is a bad abstraction: a given tool invocation might be handling multiple languages at once, or no languages at all.
Long term, we should probably just kill off the Tool.lang API. Shorter term, we should try to make its behavior more intuitive (e.g. sniffing file suffixes when available, and presenting a Lang variant based on them).
The text was updated successfully, but these errors were encountered:
This has two parts:
Tool.lang
correctly --Tool.lang
is determined only by the presence of an-x
flag or the tool class itself, meaning thatblight.CC.lang
will always reportLang.C
unless-x c++
is passed. This manifests particularly as the wronglang
value for assembly inputs:cc foo.s
ought to reportLang.Asm
(which doesn't exist yet), but reportsLang.C
instead.Tool.lang
is a bad abstraction: a given tool invocation might be handling multiple languages at once, or no languages at all.Long term, we should probably just kill off the
Tool.lang
API. Shorter term, we should try to make its behavior more intuitive (e.g. sniffing file suffixes when available, and presenting aLang
variant based on them).The text was updated successfully, but these errors were encountered: