Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find better solution for marking function aliases as definitions #638

Open
1 task done
Jezurko opened this issue Jul 1, 2024 · 0 comments
Open
1 task done

Find better solution for marking function aliases as definitions #638

Jezurko opened this issue Jul 1, 2024 · 0 comments

Comments

@Jezurko
Copy link
Collaborator

Jezurko commented Jul 1, 2024

Prerequisites

  • I have read the documentation and the proposed feature is not implemented.

Description

The current implement of isDeclaration() in core dialect is quite wonky, as it looks for a hl.alias named attribute, to detect that a function is an alias. This breaks the abstraction of core::FuncBaseOp being a generic function operation base (although so far no other dialect has an attribute for function aliasing).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant